feat(toolsearch): make the cellular identifier triad discoverable by sim/cellular#97
Merged
Merged
Conversation
…"sim" / "cellular"
The cellular identifier triad — iccid_decode (SIM serial), imsi_decode
(subscriber), imei_decode (device) — is framed in its own docs as the
identity set a SIM-swap / forensic-seizure / IMSI-catcher engagement
enumerates, but the family terms an operator actually types didn't reach
it. A probe against the live tool_search handler showed "decode this sim",
"cellular identifiers", and "sim swap forensics" surfaced NONE of the
triad: the leg names only matched by acronym ("imei", "imsi") while "sim"
and "cellular" matched nothing. Same family-discoverability gap the
v0.729 automotive and v0.738 financial synonym clusters fixed.
Adds a cellular synonym cluster to internal/toolsearch:
- "sim" -> iccid, imsi
- "cellular" -> imei, imsi, iccid, gsmtap
- "imsi" -> imsi, iccid
Both new query tokens are telecom-specific (low collision); a probe
confirmed "simulate a button press" and "similar tools" surface no
cellular decoder.
Known limitation (documented in the test): "sim card number" stays
dominated by the broad "card" cluster (nfc/mifare/emv) — a legitimate
card interpretation — so the triad ranks just out of its top results
there. The family is reachable via "decode this sim" / "cellular
identifiers" / "sim swap", which is the win this locks in.
Verification: a new regression test (TestToolSearch_CellularOblique
Discoverability) pins the three recovered queries; existing discoverability
tests still pass. task test (full short suite) 398 ok / 0 fail; task eval
12/12; golangci-lint 0 issues; go vet clean; go build ./... clean.
Wired: internal/toolsearch/search.go, internal/tools/tool_search_test.go.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes the cellular identifier triad (
iccid_decodeSIM serial,imsi_decodesubscriber,imei_decodedevice) discoverable by the family terms an operator types — "sim" and "cellular". The triad's own docs frame it as the identity set a SIM-swap / forensic-seizure / IMSI-catcher engagement enumerates, but a probe against the livetool_searchhandler showed these returned none of it (the legs only matched by acronym):decode this simiccid_decodecellular identifiersimei_decode(+ imsi/iccid)sim swap forensicsiccid_decodeSame family-discoverability pattern as the v0.729 automotive and v0.738 financial clusters.
How
Adds to
internal/toolsearch:sim→ iccid, imsicellular→ imei, imsi, iccid, gsmtapimsi→ imsi, iccidBoth new tokens are telecom-specific (low collision); verified
simulate a button press/similar toolssurface no cellular decoder.Known limitation (documented in the test):
sim card numberstays dominated by the broadcardcluster (nfc/mifare/emv) — a legitimate card interpretation — so the triad ranks just out of its top results there. The family is reachable via the phrasings above, which is the win this locks in.Verification
TestToolSearch_CellularObliqueDiscoverabilitypins the three recovered queries; existing discoverability tests pass.task test— full short suite, 398 ok / 0 fail;task eval12/12;golangci-lint0 issues;go vetclean;go build ./...clean.